Skip to content

Use a set when allocating image part names #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cakirmert wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a set when allocating image part names #1639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/docx/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _next_image_partname(self, ext: str) -> PackURI:
def image_partname(n: int) -> PackURI:
return PackURI("/word/media/image%d.%s" % (n, ext))

used_numbers = [image_part.partname.idx for image_part in self]
used_numbers = {image_part.partname.idx for image_part in self}
for n in range(1, len(self) + 1):
if n not in used_numbers:
return image_partname(n)
Expand Down