Skip to content

fix(bench): verify commander test evidence - #489

Merged
jdx merged 3 commits into
mainfrom
codex/bench-commander-evidence
Nov 7, 2026
Merged

jdx merged 3 commits into
mainfrom
codex/bench-commander-evidence

Conversation

@jdx

@jdx jdx commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

The Commander benchmark could report success without a commit or an agent-written test, and overwrote the agent's test before running the hidden cases. Require a clean committed change with a changed test file, then run the committed and hidden tests in separate checkouts. Validate Jest's per-file results and assertion counts, and report incomplete or skipped checks as unverified.

The task's reference solution passes the checker and the unsolved task fails it. Focused checker tests and Ruff's syntax/error checks pass. The benchmark still depends on the locally cached offline npm install.

AI-assisted — Tool: Codex; model: openai/unavailable; version: unavailable.


Note

Low Risk
Changes only benchmark verification scripts and tests in bench/; no runtime product or auth paths.

Overview
Tightens the Commander output-config benchmark checker so agents cannot pass without real test evidence.

The checker now requires a new commit with no dirty tracked files and at least one changed committed tests/*.test.js file. Committed and hidden Jest suites run in separate detached git worktree checkouts so hidden cases are not overlaid on the agent’s tree until the hidden phase. Jest is invoked with JSON output and results are cross-checked (counts, per-suite paths, assertion statuses); failures, missing reports, skipped/pending tests, or incomplete runs surface as hard failures or UNVERIFIED notes via _check.

Adds bench/tests/test_commander_checker.py with unit and integration-style tests for report validation, Jest errors/timeouts, and isolated checkout behavior (including hidden-test target tampering).

Reviewed by Cursor Bugbot for commit 83b45c3. Bugbot is set up for automated code reviews on this repo. Configure here.

AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aafabe6c-f679-42a1-a072-0b8f37ad207a
Commits

Reviewing files that changed from the base of the PR and between 11649ff and 83b45c3.

Files selected for processing: 2

  • bench/tasks/commander-output-config/check.py
  • bench/tests/test_commander_checker.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The changes since the previous review appear safe to merge.

Summary

The PR requires committed test evidence and runs committed and hidden tests in separate checkouts.

Changes since the previous review:

  • The Commander checker now verifies committed tests and hidden cases separately.

No new actionable issues were found.

Reviews (3) · Last reviewed commit: "fix(bench): protect commander hidden tes..." · Reviewed by Greptile

Comment thread bench/tests/test_commander_checker.py Resolved
AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
greptile-apps[bot]
greptile-apps Bot previously approved these changes Nov 7, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 10c65a5. Configure here.

AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
@greptile-apps
greptile-apps Bot dismissed their stale review November 7, 2026 11:51

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@jdx
jdx merged commit f39f6d3 into main Nov 7, 2026
16 checks passed
@jdx
jdx deleted the codex/bench-commander-evidence branch November 7, 2026 15:02
@jdx jdx mentioned this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant