Repository navigation
fix(bench): verify commander test evidence - #489
Conversation
AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
[Low impact] The changes since the previous review appear safe to merge. SummaryThe PR requires committed test evidence and runs committed and hidden tests in separate checkouts. Changes since the previous review:
No new actionable issues were found. Reviews (3) · Last reviewed commit: "fix(bench): protect commander hidden tes..." · Reviewed by Greptile |
AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 10c65a5. Configure here.
AI-Assisted: Tool: Codex; model: unavailable; version: unavailable
Dismissed because a newer commit was pushed; Greptile will re-review the current head.

The Commander benchmark could report success without a commit or an agent-written test, and overwrote the agent's test before running the hidden cases. Require a clean committed change with a changed test file, then run the committed and hidden tests in separate checkouts. Validate Jest's per-file results and assertion counts, and report incomplete or skipped checks as unverified.
The task's reference solution passes the checker and the unsolved task fails it. Focused checker tests and Ruff's syntax/error checks pass. The benchmark still depends on the locally cached offline npm install.
AI-assisted — Tool: Codex; model: openai/unavailable; version: unavailable.
Note
Low Risk
Changes only benchmark verification scripts and tests in
bench/; no runtime product or auth paths.Overview
Tightens the Commander output-config benchmark checker so agents cannot pass without real test evidence.
The checker now requires a new commit with no dirty tracked files and at least one changed committed
tests/*.test.jsfile. Committed and hidden Jest suites run in separate detachedgit worktreecheckouts so hidden cases are not overlaid on the agent’s tree until the hidden phase. Jest is invoked with JSON output and results are cross-checked (counts, per-suite paths, assertion statuses); failures, missing reports, skipped/pending tests, or incomplete runs surface as hard failures orUNVERIFIEDnotes via_check.Adds
bench/tests/test_commander_checker.pywith unit and integration-style tests for report validation, Jest errors/timeouts, and isolated checkout behavior (including hidden-test target tampering).Reviewed by Cursor Bugbot for commit 83b45c3. Bugbot is set up for automated code reviews on this repo. Configure here.