Repository navigation
fix(release): select exactly one package per package-specific tag - #53
Merged
Merged
Conversation
Replace shared v-tag matching with an explicit package tag (cli-vX, loader-vX, modules-vX) or the same ref via workflow_dispatch. Verify that package.json version equals the tag version. Unknown or shared v-tags fail closed and do not stage.
Pass the package ref through RELEASE_REF instead of interpolating it into shell. Reject anything outside cli|loader|modules-vX.Y.Z with an optional prerelease suffix. workflow_dispatch checks out that ref with no stored credentials. Tests cover injection and malformed refs.
Check out refs/tags/<validated ref> so a same-named branch cannot win. Fail the job when stage_dir is missing instead of skipping. An empty CLI argument does not fall back to the environment; only an omitted argument may use RELEASE_REF or GITHUB_REF_NAME. Process tests cover main() exit status, GITHUB_OUTPUT, and the workflow shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release selection no longer derives packages from a shared
v*tag. Exactly one package is staged, via a package-specific tag (cli-vX,loader-vX,modules-vX) or the same value as aworkflow_dispatchinputref.-vmust match that package'spackage.jsoncharacter-for-character (no semver compare, no registry lookup).v*tags no longer start staging.refs/tags/<validated ref>so a same-named branch cannot win.npm stage publishunder dist-tagnext, neverlatest.Head:
470402ac8afbfee81533706301aa9e38a958c5ec(Donna §7a PASS, report20261107-155643, 47/47). Base: currentrelease/2.2.xatd531d300a9a793618ecc9230328d3db6f7cb7cd0(fast-forward of those three commits only).Files
.github/workflows/release.ymlscripts/check-release-version.mjspackages/cli/src/lib/__tests__/check-release-version.test.jsRELEASING.mdOut of scope
No tag, no npm stage, no publish, no re-release of
@stagepass/modules@2.2.2. A later release still needs an explicit package and version.Checklist
fix/**push (cerebro-stagepass)470402areachable; no squash/rebase)